feat(time): add femtoseconds and picoseconds to best units

Closes #588
jonahsnider · Apr 21, 2023 · e6ec41d · e6ec41d
1 parent 119fed1
commit e6ec41d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 17 deletions.
diff --git a/packages/bundled-conversions/src/index.ts b/packages/bundled-conversions/src/index.ts
@@ -1158,14 +1158,16 @@ export const bestUnits = {
 		[[1, 'psi']],
 		[[1, 'F']],
 		[
-			[1, 'ns'],
-			[1000, 'μs'],
-			[1000000, 'ms'],
-			[1000000000, 's'],
-			[60000000000, 'min'],
-			[3600000000000, 'h'],
-			[86400000000000, 'd'],
-			[31536000000000000, 'y'],
+			[1, 'fs'],
+			[1000, 'ps'],
+			[1000000, 'ns'],
+			[1000000000, 'μs'],
+			[1000000000000, 'ms'],
+			[1000000000000000, 's'],
+			[60000000000000000, 'min'],
+			[3600000000000000000, 'h'],
+			[86400000000000000000, 'd'],
+			[3.1536e22, 'y'],
 		],
 		[
 			[1, 'tsp'],
@@ -1218,14 +1220,16 @@ export const bestUnits = {
 		[[1, 'Pa']],
 		[[1, 'C']],
 		[
-			[1, 'ns'],
-			[1000, 'μs'],
-			[1000000, 'ms'],
-			[1000000000, 's'],
-			[60000000000, 'min'],
-			[3600000000000, 'h'],
-			[86400000000000, 'd'],
-			[31536000000000000, 'y'],
+			[1, 'fs'],
+			[1000, 'ps'],
+			[1000000, 'ns'],
+			[1000000000, 'μs'],
+			[1000000000000, 'ms'],
+			[1000000000000000, 's'],
+			[60000000000000000, 'min'],
+			[3600000000000000000, 'h'],
+			[86400000000000000000, 'd'],
+			[3.1536e22, 'y'],
 		],
 		[
 			[1, 'mL'],

diff --git a/packages/conversions/src/conversions/time.ts b/packages/conversions/src/conversions/time.ts
@@ -5,7 +5,7 @@ import {Id} from '../types/index.js';
 
 export const time: ReadonlyDeep<Family> = {
 	id: Id.Time,
-	best: ['ns', 'μs', 'ms', 's', 'min', 'h', 'd', 'y'],
+	best: ['fs', 'ps', 'ns', 'μs', 'ms', 's', 'min', 'h', 'd', 'y'],
 	conversions: [
 		{names: ['second', 'seconds'], symbols: ['s'], ratio: 1},
 		...expandMacro(Macros.si, {names: ['second', 'seconds'], symbols: ['s'], ratio: 1}),