Milestones list localization

jonan · Dec 16, 2017 · 2d6fe3f · 2d6fe3f
1 parent ae5596c
commit 2d6fe3f
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/app/src/main/java/com/github/mobile/ui/repo/MilestoneListAdapter.java b/app/src/main/java/com/github/mobile/ui/repo/MilestoneListAdapter.java
@@ -30,6 +30,7 @@
  */
 public class MilestoneListAdapter extends SingleTypeAdapter<Milestone> {
 
+    private final Context context;
     /**
      * Create milestone list adapter
      *
@@ -40,6 +41,7 @@ public class MilestoneListAdapter extends SingleTypeAdapter<Milestone> {
     public MilestoneListAdapter(final Context context,
                                 final Milestone[] elements, final AvatarLoader avatars) {
         super(LayoutInflater.from(context), R.layout.milestone_item);
+        this.context = context.getApplicationContext();
         setItems(elements);
     }
 
@@ -60,11 +62,11 @@ protected int[] getChildViewIds() {
 
     @Override
     protected void update(int position, Milestone milestone) {
-        SimpleDateFormat sdf = new SimpleDateFormat("dd.MMM.yyyy");
+        SimpleDateFormat sdf = new SimpleDateFormat("dd MMM yyyy");
 
         setText(0, milestone.getTitle());
-        setText(1, "Due by " + sdf.format(milestone.getDueOn()));
-        setText(2, "Opened: " + String.valueOf(milestone.getOpenIssues()));
-        setText(3, "Closed: " + String.valueOf(milestone.getClosedIssues()));
+        setText(1, context.getString(R.string.ms_due_by) + sdf.format(milestone.getDueOn()));
+        setText(2, context.getString(R.string.ms_opened_issues) + String.valueOf(milestone.getOpenIssues()));
+        setText(3, context.getString(R.string.ms_closed_issues) + String.valueOf(milestone.getClosedIssues()));
     }
 }
diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml
@@ -344,5 +344,8 @@
     <string name="render_markdown">Отобразить Markdown</string>
     <string name="copy_hash">Копировать хэш</string>
     <string name="toast_msg_copied">Скопировано в буфер обмена</string>
+    <string name="ms_closed_issues">"Закрытые: "</string>
+    <string name="ms_due_by">"До "</string>
+    <string name="ms_opened_issues">"Открытые: "</string>
 
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -346,5 +346,8 @@
     <string name="copy_hash">Copy hash</string>
     <string name="toast_msg_copied">Copied to clipboard</string>
     <string name="parent_repo">Parent repository</string>
+    <string name="ms_due_by">Due by</string>
+    <string name="ms_opened_issues">Opened:</string>
+    <string name="ms_closed_issues">Closed:</string>
 
 </resources>