Crash using # in refs view

[heiko3]

tig crashes when enabling line-numbers in refs view.

Steps to reproduce:

• start tig (commit 5530752)
• 'r' (refs view)
• '#' (toggle line-numbers)

    Core was generated by `src/tig'.
    Program terminated with signal SIGFPE, Arithmetic exception.
    #0  0x00000000004130c6 in draw_lineno_custom (view=0x649840 <refs_view>, column=0x17d7650, lineno=2) at src/draw.c:306
    306     if (lineno == 1 || (lineno % column->opt.line_number.interval) == 0) {
    #0  0x00000000004130c6 in draw_lineno_custom (view=0x649840 <refs_view>, column=0x17d7650, lineno=2) at src/draw.c:306
        number = "\000}(\031\377\177\000\000*"
        digits3 = 3
        max = 3
        text = 0x0
        separator = 4194424
    #1  0x00000000004131bf in draw_lineno (view=0x649840 <refs_view>, column=0x17d7650, lineno=2) at src/draw.c:324
    No locals.
    #2  0x00000000004139e3 in view_column_draw (view=0x649840 <refs_view>, line=0x18d2320, lineno=1) at src/draw.c:504
        mode = 0
        column = 0x17d7650
        column_data = {section = 0x0, author = 0x17d90d0, commit_title = 0x18d1858 "Fix segfault in the stage view when view->parent is NULL", date = 0x18d1848, file_name = 0x0, file_size = 0x0, graph = 0x0, graph_canvas = 0x0, id = 0x17d707c "55307527b7bd5fa232544f8e536fb146a9909e8d", line_number = 0x0, mode = 0x0, ref = 0x17d7070, reflog = 0x0, refs = 0x0, status = 0x0, text = 0x0}
    #3  0x0000000000413e44 in draw_view_line (view=0x649840 <refs_view>, lineno=1) at src/draw.c:601
        line = 0x18d2320
        selected = false
    #4  0x0000000000413fd8 in redraw_view_from (view=0x649840 <refs_view>, lineno=1) at src/draw.c:640
        __PRETTY_FUNCTION__ = "redraw_view_from"
    #5  0x0000000000414039 in redraw_view (view=0x649840 <refs_view>) at src/draw.c:651
    No locals.
    #6  0x000000000041521e in prompt_update_display (flags=VIEW_NO_FLAGS) at src/prompt.c:725
        view = 0x649840 <refs_view>
        i = 0
    #7  0x000000000041594c in run_prompt_command (view=0x649840 <refs_view>, argv=0x193b2a0) at src/prompt.c:847
        flags = VIEW_NO_FLAGS
        code = SUCCESS
        action = 0x64d380 <status_custom_message> "set line-number-display = yes"
        request = 9
        cmd = 0x18d1f50 "toggle"
        cmdlen = 6
    #8  0x0000000000415ca2 in exec_run_request (view=0x649840 <refs_view>, req=0x17dbab0) at src/prompt.c:925
        argv = 0x193b2a0
        confirmed = false
        request = REQ_NONE
        cmd = "toggle\000line-number", '\000' <repeats 15 times>, "\215(\031\377\177\000\000\b\214_\250\320\177\000\000\020\000\000\000\000\000\000\000)\307`\250\320\177\000\000\000\000\000\000\017\000\000\000\001\000\000\000a\000\000\000 \215(\031\377\177\000\000pR>\250\320\177\000\000\000\000\000\000\000\000\000\000`", '\000' <repeats 23 times>, "\371\001\000\000\000\000\000\000\377\001\000\000\000\000\000\000\033[1;140H\000\215(\031\377\177\000\000\001\000\000\000\000\000\000\000\360\215(\031\377\177\000\000\001\000\000\000\000\000\000\000:3`\250\320\177\000\000\200\215(\031\377\177\000\000"...
        req_argv = {0x7fff19288c90 "toggle", 0x7fff19288c97 "line-number", 0x0, 0x1b435b1b435b1b43 <error: Cannot access memory at address 0x1b435b1b435b1b43>, 0x435b1b435b1b435b <error: Cannot access memory at address 0x435b1b435b1b435b>, 0x5b1b435b1b435b1b <error: Cannot access memory at address 0x5b1b435b1b435b1b>, 0x1b435b1b435b1b43 <error: Cannot access memory at address 0x1b435b1b435b1b43>, 0x435b1b435b1b435b <error: Cannot access memory at address 0x435b1b435b1b435b>, 0x5b1b435b1b435b1b <error: Cannot access memory at address 0x5b1b435b1b435b1b>, 0x1b435b1b435b1b43 <error: Cannot access memory at address 0x1b435b1b435b1b43>, 0x435b1b435b1b435b <error: Cannot access memory at address 0x435b1b435b1b435b>, 0x5b1b435b1b435b1b <error: Cannot access memory at address 0x5b1b435b1b435b1b>, 0x1b435b1b435b1b43 <error: Cannot access memory at address 0x1b435b1b435b1b43>, 0x435b1b435b1b435b <error: Cannot access memory at address 0x435b1b435b1b435b>, 0x5b1b435b1b435b1b <error: Cannot access memory at address 0x5b1b435b1b435b1b>, 0x1b435b1b435b1b43 <error: Cannot access memory at address 0x1b435b1b435b1b43>, 0x435b1b435b1b435b <error: Cannot access memory at address 0x435b1b435b1b435b>, 0x5b1b435b1b435b1b <error: Cannot access memory at address 0x5b1b435b1b435b1b>, 0x7fd0a85f0043 <error: Cannot access memory at address 0x7fd0a85f0043>, 0x7fd0a85f8df0 <SP> "\340\371}\001", 0x700 <error: Cannot access memory at address 0x700>, 0xfa13967a5004d300 <error: Cannot access memory at address 0xfa13967a5004d300>, 0x700 <error: Cannot access memory at address 0x700>, 0x7fd0a8618be0 "\351\257\375\377\377\017\266\004\312H\205\300\017\205x\001", 0x7fd0a83e5270 <_nc_outch> "SH\203\354 dH\213\004%(", 0xfa13967a5004d300 <error: Cannot access memory at address 0xfa13967a5004d300>, 0x7fd0a85f8440 <_nc_prescreen> "\001", 0xfa13967a5004d300 <error: Cannot access memory at address 0xfa13967a5004d300>, 0x7fd0a85f8c08 <cur_term> "\340N}\001", 0x7fd0a83e53e3 <tputs+147> "\017\266U", 0x100000000000001 <error: Cannot access memory at address 0x100000000000001>, 0x7fd0a83e5270 <_nc_outch> "SH\203\354 dH\213\004%("}
        req_argc = 2
    #9  0x00000000004032a1 in open_run_request (view=0x649840 <refs_view>, request=587) at src/tig.c:137
        req = 0x17dbab0
    #10 0x00000000004032df in view_driver (view=0x649840 <refs_view>, request=587) at src/tig.c:153
        i = 0
    #11 0x000000000040449d in main (argc=1, argv=0x7fff19289678) at src/tig.c:648
        codeset = 0x7fd0a7b4b30c <error: Cannot access memory at address 0x7fd0a7b4b30c>
        pager_mode = false
        request = 587
        view = 0x649840 <refs_view>

[jonas]

Thanks. tigrc didn't specify any interval which resulted in division with zero.
When the interval is zero it now defaults to use 5.

[heiko3]

Thanks for fixing it.