Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstaged changes should be shown above staged changes #383

Closed
proski opened this issue Feb 23, 2015 · 2 comments
Closed

Unstaged changes should be shown above staged changes #383

proski opened this issue Feb 23, 2015 · 2 comments
Milestone

Comments

@proski
Copy link
Contributor

proski commented Feb 23, 2015

Staged changes are shown above unstaged changes. That's not the logical order. Unstaged changes can modify staged changes (see screenshot) but not the other way around. It's just like a newer commit can modify text added by an older commit. New commits are shown above old commits, so it's logical to follow that pattern for local changes.

To look at it another way, staged changes are closer to the commits. It's trivial to commit staged changes only - it's the default git commit behavior. It's much trickier to commit unstaged changes and omit staged changes, especially if both affect the same file. Thus staged changes should be closer to commits, i.e. lower.

tig

@proski proski changed the title Unstaged changes should be shown above stages changes Unstaged changes should be shown above staged changes Feb 23, 2015
@jonas
Copy link
Owner

jonas commented Feb 23, 2015

That's a good point. gitk does it that way also, which is the where the feature was stolen from.

@jonas jonas added this to the tig-2.1 milestone Feb 25, 2015
@jonas jonas closed this as completed in c6aea2e Feb 25, 2015
@proski
Copy link
Contributor Author

proski commented Feb 26, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants