Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstaged changes view closes after every staging command #399

Closed
joshproehl opened this issue Apr 5, 2015 · 1 comment
Closed

Unstaged changes view closes after every staging command #399

joshproehl opened this issue Apr 5, 2015 · 1 comment
Milestone

Comments

@joshproehl
Copy link

Since upgrading to 2.1 on both OSX (homebrew) and ArchLinux:

Open tig
Open unstaged changes
Select a line/chunk to stage
Press 1 or u to stage

Expected result: Chunk/line is staged, unstaged changes view remains open for further staging, views refresh to indicate that there are now staged changes.
Actual result: Chunk/line is staged, but unstaged change view closes immediately, views do not refresh. (Re-opening unstaged changes view usually does not have the refreshed staging details)

(On my Arch box everything was working fine on 2.0.x, and upgrading only the tig package caused this behavior to begin.)

@jonas jonas closed this as completed in 8894095 Apr 7, 2015
@jonas
Copy link
Owner

jonas commented Apr 7, 2015

Thanks for reporting this. I've added an additional check for this feature. The regression was introduced when the rendering of staged/unstaged changes lines was moved from main_open to when the HEAD of the current branch is rendered.

@jonas jonas modified the milestone: tig-2.1.1 Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants