Update Discord voice timeout #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From my own testing, I've come to the conclusion that the default timeout is too short - the bot would stop playing music if the voice connection got lost for a moment or if it was moved to another channel. I think 5 seconds is plenty of time for it to reconnect to voice if it disconnects. Thanks for this great project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From my own testing, I've come to the conclusion that the default timeout is too short - the bot would stop playing music if the voice connection got lost for a moment or if it was moved to another channel. I think 5 seconds is plenty of time for it to reconnect to voice if it disconnects.
It could probably be even shorter, but as far as I'm aware, there's no downside to it being a higher value, besides the bot realizing it lost connection to the voice channel a few seconds later if it doesn't manage to reconnect. I believe the trade-off is worth it though.
Thanks for this great project.