Fix different warnings (#723)

.github/workflows/ci.yaml

@@ -113,6 +113,9 @@ jobs:
         run: |
           cargo install cargo-tarpaulin
           cargo tarpaulin --out xml --workspace --all-features -- --test-threads=1
+        env:
+          # https://github.com/xd009642/tarpaulin/issues/1499
+          CARGO_PROFILE_DEV_DEBUG: 1
       - name: Upload to codecov.io
         uses: codecov/codecov-action@v4
         if: matrix.rust == 'stable' && matrix.os == 'ubuntu-latest'

Cargo.toml

@@ -42,6 +42,9 @@ variant_size_differences = "warn"
 # explicit_auto_deref suggests code that does not compile
 # https://github.com/rust-lang/rust-clippy/issues/9841
 explicit_auto_deref = "allow"
+# Triggers in macro generated code of darling
+# https://github.com/rust-lang/rust-clippy/issues/12643
+manual-unwrap-or-default = "allow"
 
 # alloc_instead_of_core = "warn"
 # Checks for usage of `cloned()` on an `Iterator` or `Option` where `copied()` could be used instead.

serde_with/src/utils.rs

@@ -113,12 +113,8 @@ where
     }
 }
 
-pub(crate) fn duration_as_secs_f64(dur: &Duration) -> f64 {
-    (dur.as_secs() as f64) + (dur.subsec_nanos() as f64) / (NANOS_PER_SEC as f64)
-}
-
 pub(crate) fn duration_signed_from_secs_f64(secs: f64) -> Result<DurationSigned, &'static str> {
-    const MAX_NANOS_F64: f64 = ((u64::max_value() as u128 + 1) * (NANOS_PER_SEC as u128)) as f64;
+    const MAX_NANOS_F64: f64 = ((u64::MAX as u128 + 1) * (NANOS_PER_SEC as u128)) as f64;
     // TODO why are the seconds converted to nanoseconds first?
     // Does it make sense to just truncate the value?
     let mut nanos = secs * (NANOS_PER_SEC as f64);

serde_with/src/utils/duration.rs

@@ -225,7 +225,7 @@ where
     {
         source
             .sign
-            .apply(utils::duration_as_secs_f64(&source.duration))
+            .apply(source.duration.as_secs_f64())
             .serialize(serializer)
     }
 }
@@ -241,7 +241,7 @@ where
     {
         source
             .sign
-            .apply(utils::duration_as_secs_f64(&source.duration))
+            .apply(source.duration.as_secs_f64())
             .to_string()
             .serialize(serializer)
     }

serde_with/tests/schemars_0_8.rs

@@ -374,6 +374,7 @@ mod derive {
         field: u32,
     }
 
+    #[allow(dead_code)]
     #[serde_as]
     #[derive(Serialize)]
     #[cfg_attr(any(), derive(JsonSchema))]

serde_with/tests/serde_as/lib.rs

@@ -580,7 +580,7 @@ fn test_serialize_reference() {
     #[derive(Debug, Serialize)]
     struct S1a<'a>(#[serde_as(as = "&Vec<DisplayFromStr>")] &'a Vec<u32>);
     check_serialization(
-        S1(&vec![1, 2]),
+        S1a(&vec![1, 2]),
         expect![[r#"
         [
           "1",
@@ -592,7 +592,7 @@ fn test_serialize_reference() {
     #[derive(Debug, Serialize)]
     struct S1Mut<'a>(#[serde_as(as = "Vec<DisplayFromStr>")] &'a mut Vec<u32>);
     check_serialization(
-        S1(&vec![1, 2]),
+        S1Mut(&mut vec![1, 2]),
         expect![[r#"
         [
           "1",
@@ -604,7 +604,7 @@ fn test_serialize_reference() {
     #[derive(Debug, Serialize)]
     struct S1aMut<'a>(#[serde_as(as = "&mut Vec<DisplayFromStr>")] &'a mut Vec<u32>);
     check_serialization(
-        S1(&vec![1, 2]),
+        S1aMut(&mut vec![1, 2]),
         expect![[r#"
         [
           "1",

serde_with_macros/src/lib.rs

@@ -229,6 +229,7 @@ where
 /// ```rust
 /// # use serde::Serialize;
 /// #
+/// # #[allow(dead_code)]
 /// #[derive(Serialize)]
 /// struct Data {
 ///     #[serde(skip_serializing_if = "Option::is_none")]
@@ -248,6 +249,8 @@ where
 /// ```rust
 /// # use serde::Serialize;
 /// # use serde_with_macros::skip_serializing_none;
+/// #
+/// # #[allow(dead_code)]
 /// #[skip_serializing_none]
 /// #[derive(Serialize)]
 /// struct Data {
@@ -278,8 +281,10 @@ where
 /// ```rust
 /// # use serde::Serialize;
 /// # use serde_with_macros::skip_serializing_none;
+/// # #[allow(dead_code)]
 /// type MyOption<T> = Option<T>;
 ///
+/// # #[allow(dead_code)]
 /// #[skip_serializing_none]
 /// #[derive(Serialize)]
 /// struct Data {