Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on serde's "derive" feature #694

Merged
merged 1 commit into from Feb 8, 2024

Conversation

dtolnay
Copy link
Contributor

@dtolnay dtolnay commented Feb 8, 2024

This allows serde, and other crates downstream of it like serde_json, to compile in parallel with serde_derive. Without this PR, in any dependency graph that pulls in serde_with, first serde_derive would need to compile, then serde would need to compile, then serde_json would need to compile.

sharkdp/bat#2815 has a diagram of the impact of this change.

@dtolnay
Copy link
Contributor Author

dtolnay commented Feb 8, 2024

CI failures look unrelated to this change. See #695.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b17850) 65.41% compared to head (5e6a115) 65.41%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #694   +/-   ##
=======================================
  Coverage   65.41%   65.41%           
=======================================
  Files          38       38           
  Lines        2322     2322           
=======================================
  Hits         1519     1519           
  Misses        803      803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonasbb
Copy link
Owner

jonasbb commented Feb 8, 2024

Thank you for the PRs. This looks ok, but I think it re-introduces the risk of mismatching serde dependency versions. Bumping the serde dependency to v1.0.186 should mitigate this. I can bump the dependency and release a new patch version.

@jonasbb jonasbb merged commit 6211d20 into jonasbb:master Feb 8, 2024
23 checks passed
@dtolnay
Copy link
Contributor Author

dtolnay commented Feb 8, 2024

Thank you, that would be great. Yes, serde 1.0.186+ contains serde-rs/serde#2588 which eliminates the version mismatch possibility.

@dtolnay dtolnay deleted the noderive branch February 8, 2024 23:38
@jonasbb
Copy link
Owner

jonasbb commented Feb 8, 2024

v3.6.1 is published now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants