guarantee serde is in lockstep with serde_derive
#2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
its going to take a better |
Merged
|
i don't seem to be able to get the "Outdated" check to pass, since the new CI check has to rely on an old version of |
dtolnay
force-pushed
the
use-impossible-cfg-to-lockstep-serde-derive
branch
from
61998fc
to
2ea7e13
Compare
This was referenced Aug 23, 2023
Merged
KamilaBorowska
added a commit
to KamilaBorowska/rust-url
that referenced
this pull request
Aug 30, 2023
When serde's derive feature is used, serde_derive must be compiled before serde can be, as serde with that feature has a serde_derive dependency. As of serde 1.0.186, this issue can be avoided by adding a separate serde_derive dependency due to the fact that serde 1.0.186 has a never-applicable dependency on serde_derive, which ensures that there is no incompatible version of serde_derive in a program [1]. Because MSRV being set to 1.56, it's not possible to use the dep: syntax in features, so serde crate needs to be renamed. This should improve compilation times of programs that use url with its serde feature, provided it doesn't have other crates that use serde with its derive feature. [1]: serde-rs/serde#2588
KamilaBorowska
added a commit
to KamilaBorowska/either
that referenced
this pull request
Sep 2, 2023
When serde's derive feature is used, serde_derive must be compiled before serde can be, as serde with that feature has a serde_derive dependency. As of serde 1.0.186, this issue can be avoided by adding a separate serde_derive dependency due to the fact that serde 1.0.186 has a never-applicable dependency on serde_derive, which ensures that there is no incompatible version of serde_derive in a program [1]. Because MSRV being set to 1.36, it's not possible to use the dep: syntax in features, so serde crate needs to be renamed. This should improve compilation times of programs that use either with its serde feature, provided it doesn't have other crates that use serde with its derive feature. [1]: serde-rs/serde#2588
KamilaBorowska
added a commit
to KamilaBorowska/either
that referenced
this pull request
Sep 2, 2023
When serde's derive feature is used, serde_derive must be compiled before serde can be, as serde with that feature has a serde_derive dependency. As of serde 1.0.186, this issue can be avoided by adding a separate serde_derive dependency due to the fact that serde 1.0.186 has a never-applicable dependency on serde_derive, which ensures that there is no incompatible version of serde_derive in a program [1]. Because MSRV being set to 1.36, it's not possible to use the dep: syntax in features, so serde crate needs to be renamed. This should improve compilation times of programs that use either with its serde feature, provided it doesn't have other crates that use serde with its derive feature. Fixes rayon-rs#86. [1]: serde-rs/serde#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
derivefeature instead ofserde_derivedirectly #2584.serde_derive.Solution
serde_deriveinCargo.lockfiles for projects that includeserdewithoutserde_derivebeing forced as a dependency, so users can do the following in theirCargo.toml:serdeandserde_derivehave the same version in a new dummy crate, though this does introduce some dev-dependencies which could be split out.