serde_conv: Allow clippy::ptr_arg
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With String as t, &String would trigger clippy::ptr_arg.
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 79.39% 79.39%
=======================================
Files 45 45
Lines 2577 2577
=======================================
Hits 2046 2046
Misses 531 531
Continue to review full report at Codecov.
|
|
Thank you. Yeah it makes sense to suppress the lints here. I wonder if there are other ones which might crop up. I guess they can be dealt with then. bors r+ |
|
Build succeeded: |
jonasbb
added a commit
that referenced
this pull request
Apr 17, 2024
jonasbb
added a commit
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
Stringast,&Stringwould triggerclippy::ptr_arg.What do you think?