Add BorrowCow type to force Cow to borrow str from the input #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
==========================================
- Coverage 77.90% 76.77% -1.14%
==========================================
Files 45 45
Lines 2616 2704 +88
==========================================
+ Hits 2038 2076 +38
- Misses 578 628 +50
Continue to review full report at Codecov.
|
This is a convenience feature and works since `BorrowCow` is only implemented for types which can borrow from the input. The behaviour can be prohibited, by providing a borrow annotation manually. Duplicate annotations would lead to an error, so the macro will not do that. The borrow annotation could be wrong, if the field type has multiple lifetime parameters, but not all should borrow.
This implementation differs from the `Bytes` implementation in that it serializes the data as a sequence of u8 values, not as bytes. The deserialization is identical, borrowing if possible, otherwise creating an owned version.
`BorrowCow` only works as documented with the newest serde_with_macros version. Already bump the version, such that it cannot be forgotten later.
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs:
serde_asautomatically applyborrow?