Pbstate locking #25
Merged
Pbstate locking #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
=======================================
Coverage 68.15% 68.15%
=======================================
Files 54 54
Lines 2795 2795
=======================================
Hits 1905 1905
Misses 890 890 |
jonasblixt
force-pushed
the
pbstate-locking
branch
from
2127f7f
to
6f42b32
Compare
The library should return negative errno numbers as default.
This commit introduces flock'ing on the state file. This is needed when the library is used by more than one process. Before this change the library would load the state on the init call and keep the state in memory, any modifications are done on the in memory state and then written. This will not work when multiple processes are using the library since it's more or less guaranteed to cause data loss. Because of how flock must be implemented and because we cant keep an in memory copy of the state most of the functions have changed and the API has changed on a few places as well. Mostly because now API functions must load and check the state on every invocation and that means that they now must be able to return error codes.
This commits adds a clear/set function that takes a clear and set mask. This may be useful in situations where only modification if specific bits is desired. It might be dangerous to first call the read_board_reg function, perform modifciations and then call the set_board_reg function since another process might have done modifications to the register. The clear_set_board_reg function will acquire the lock read/modify/write and then release the lock.
jonasblixt
force-pushed
the
pbstate-locking
branch
from
6f42b32
to
dcabe0d
Compare
thebolt
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.