V2.2.0 work #43
Merged
V2.2.0 work #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 7, 2024 06:48
If a board command reset's the board the command response is never sent and will result in timeouts. This extra function let's board command reboot the system through the CM code instead, after the respons has been transmitted.
library_version tried to call a now removed c function to report version. Since everyting is versioned together nowdays we can just do the same as the CLI to report version. The 'library_version' function is keept for compability for now but might be deprecated in the future.
Instead of logging everything to the root logger. This way it's easier to selectivly control debug output from the punchboot library.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 64.75% 64.68% -0.08%
==========================================
Files 58 58
Lines 2846 2891 +45
==========================================
+ Hits 1843 1870 +27
- Misses 1003 1021 +18 ☔ View full report in Codecov by Sentry. |
added 6 commits
June 7, 2024 07:32
Actually try to find a device within the specified timeout. Before this commit the code would return early if no device was enumerated which is not the expected behaviour.
Change the usbd to be async. This way we don't have to kick the WDT in more than one place and we can allow for timeout management and periodic processing through the command mode code instead.
This uses the new async xfer calls in the CM main loop. With this change we only need to kick the WDT in one place.
Board code can optionally implement this callback. It's called whenever we're waiting for the next command.
added 4 commits
June 7, 2024 14:18
This interferes with RPBM access. At least on some devices it seems to reset the internal state between writing a command and reading the result. Therfore we can't change the partition access like this. Normally both boot partitions are updated and therefor it should be okay if either one is set to active. And regardless of partition access setting there is always one active boot partition so we should not be able to end up in a non bootable state as the comment suggested. The R/O issue fixes it self in the next boot cycle since we're usually going to be reading from the USER area, which put's the boot R/W settings back to normal.
The write function is needed to properly interact with RPMB even for just read operations.
Access to RPMB always uses the multiple blocks command even if there's just one block to be handled. RPMB access also requires us to set the block count. Because the standard says so. This seems to be different between manufacturers, at least some Micron memories seem fine without this and just works when reading blocks. Other memories refuse to do read accesses without this and the standard also says that it should be done in this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.