State internal accessors #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow suit with other classes and other accessors in the State class
Following the `_actions` accessor, add the `_conditions` accessor too
Same as there is a `_conditions` accessor for actions' conditions, we really want this accessor to separate this config out from the action's true configuration.
State consumes the 'condition' and 'resulting_state' keys from the Action configuration specified inside the State. Although these two keys are specified *as part of* the Action config, they are in fact State configuration relating to the Action, instead of true Action configuration. This addresses an issue reported by @oliwell after the 1.55 release, where OpenXPKI was confused about unexpected parameters being added to the action instantiation. While at it, clean up the code around state-specific-action configuration handling in general.
... because the accessor is called `_next_state()`.
ehuelsmann
force-pushed
the
state-internal-accessors
branch
from
4e090b7
to
857ff54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate state's action-related data from actual Action configuration.
This solves a problem reported by @oliwel due to the 1.55 release, which confuses OpenXPKI due to the 'resulting_state' and 'condition' keys being part of the action configuration.
Type of change
Please delete options that are not relevant.
Arguably, this is a bugfix.
Checklist: