A third party disable for and within Slingshot's try+
#196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This successfully avoids the suspicious-expression warning in a simple test case. I don't understand what :within-depth really means. The "10" I have in there was the minimum that successfully suppressed the warning. An alternate approach for avoiding this warning is this pull request scgilardi/slingshot#55
| {:linter :suspicious-expression | ||
| :for-macro 'clojure.core/and | ||
| :if-inside-macroexpansion-of #{'slingshot.slingshot/try+} | ||
| :within-depth 10 |
There was a problem hiding this comment.
scgilardi/slingshot#55 (comment) indicates that :within-depth 10 is not high enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This successfully avoids the suspicious-expression warning in a simple
test case. I don't understand what :within-depth really means. The
"10" I have in there was the minimum that successfully suppressed the
warning. An alternate approach for avoiding this warning is this pull
request scgilardi/slingshot#55