Fix Clojure 1.9 warnings #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I appreciate the pull request, and the time it takes to create and test such things. I have recently committed updates to the versions of tools.analyzer, tools.analyzer.jvm, and tools.reader that are copied in to Eastwood, to their most recent versions: fddfebb I also removed the uri? function in the eastwood.utils namespace, since it was identical to the same-named function recently added to Clojure 1.9.0, and Eastwood wasn't even using it (weird): 12a90b5 Closing this PR as the issues it fixes have been addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the warning in #232 as well as a couple of others about
boolean?