Fixes failing collection tests #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vector expressions are now correctly rewritten
|
Any thoughts on getting this merged? It's not good having failing tests in master from a potential contributor's point of view - I don't know when I'm breaking things. |
|
Thanks for this, I'm just chewing it over a little bit before merging it. |
|
I think this is a bug in core.logic. Maybe it's been fixed in the latest release? |
|
Its perhaps not the most ideal solution, but i think its to do with the fact that '[ ]' has a meaning in core.logic. If its fixed in core.logic that would be great. |
…ion-rules Conflicts: src/kibit/rules/util.clj
|
Thanks for putting this together Thomas, I really appreciate it. I don't think we'll need this pull request though, as the bug was fixed in clojure/core.logic@dba7c69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one of the problems from issue #89 which is tests from rules.collections failing.
Basically any rewrite in a vector is not being applied correctly, for example:
We end up with:
Instead of:
By converting all vector literals into an s-expression of form
(:kibit.rules/vector ...)we can apply the rewrites and then go back to the square-bracket notation.There maybe a more trivial way, but this seems to work and all
rule.collectionstests pass now.