Change to no-loop-statement.

CHANGELOG.md

@@ -17,7 +17,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 * New rule `no-if-statement`. See [readme](https://github.com/jonaskello/tslint-immutable#no-if-statement) for more info and [#54](https://github.com/jonaskello/tslint-immutable/issues/54) for discussion.
 
-* New rule `no-for-statement`. See [readme](https://github.com/jonaskello/tslint-immutable#no-for-statement) for more info and [#54](https://github.com/jonaskello/tslint-immutable/issues/54) for discussion.
+* New rule `no-loop-statement`. See [readme](https://github.com/jonaskello/tslint-immutable#no-loop-statement) for more info and [#54](https://github.com/jonaskello/tslint-immutable/issues/54) for discussion.
 
 ### Fixed
 

README.md

@@ -47,7 +47,7 @@ In addition to immutable rules this project also contains a few rules for enforc
   * [no-mixed-interface](#no-mixed-interface)
   * [no-expression-statement](#no-expression-statement)
   * [no-if-statement](#no-if-statement)
-  * [no-for-statement](#no-for-statement)
+  * [no-loop-statement](#no-loop-statement)
 * [Recommended built-in rules](#recommended-built-in-rules)
 
 ## Immutability rules
@@ -370,9 +370,9 @@ const x = i === 1 ? 2 : 3;
 
 For more background see this [blog post](https://hackernoon.com/rethinking-javascript-the-if-statement-b158a61cd6cb) and discussion in [#54](https://github.com/jonaskello/tslint-immutable/issues/54).
 
-### no-for-statement
+### no-loop-statement
 
-In functional programming we want everthing to be an expression that returns a value. The `for` statement is not an expression. This rule disallows for statements, including `for of` and `for in`.
+In functional programming we want everthing to be an expression that returns a value. Loops in typescript are statements so they are not a good fit for a functional programming style. This rule disallows for loop statements, including `for`, `for...of`, `for...in`, `while`, and `do...while`.
 
 ```typescript
 const numbers = [1, 2, 3];

src/noForStatementRule.ts → src/noLoopStatementRule.ts

@@ -11,7 +11,7 @@ type Options = {};
 // tslint:disable-next-line:variable-name
 export const Rule = createCheckNodeRule(
   checkNode,
-  "Unexpected for, use map or reduce instead."
+  "Unexpected loop, use map or reduce instead."
 );
 
 function checkNode(
@@ -21,7 +21,9 @@ function checkNode(
   return node &&
     (node.kind === ts.SyntaxKind.ForStatement ||
       node.kind === ts.SyntaxKind.ForInStatement ||
-      node.kind === ts.SyntaxKind.ForOfStatement)
+      node.kind === ts.SyntaxKind.ForOfStatement ||
+      node.kind === ts.SyntaxKind.WhileStatement ||
+      node.kind === ts.SyntaxKind.DoStatement)
     ? { invalidNodes: [createInvalidNode(node)] }
     : {
         invalidNodes: []

test/rules/no-for-statement/default/test.ts.lint → test/rules/no-loop-statement/default/test.ts.lint

@@ -21,4 +21,18 @@ for(const x of y) {
 }
 ~ [failure]
 
-[failure]: Unexpected for, use map or reduce instead.
+while(1 === 1) {
+~~~~~~~~~~~~~~~~~~~
+	console.log("a");
+~~~~~~~~~~~~~~~~~~~
+}
+~ [failure]
+
+do {
+~~~~
+	console.log("a");
+~~~~~~~~~~~~~~~~~~~
+} while(1 === 1)
+~~~~~~~~~~~~~~~~ [failure]
+
+[failure]: Unexpected loop, use map or reduce instead.

test/rules/no-for-statement/default/tslint.json → test/rules/no-loop-statement/default/tslint.json

@@ -1,6 +1,6 @@
 {
   "rulesDirectory": ["../../../../rules"],
   "rules": {
-    "no-for-statement": true
+    "no-loop-statement": true
   }
 }

tslint-immutable.json

@@ -4,9 +4,9 @@
     "no-class": false,
     "no-delete": false,
     "no-expression-statement": false,
-    "no-for-statement": false,
     "no-if-statement": false,
     "no-let": false,
+    "no-loop-statement": false,
     "no-method-signature": false,
     "no-mixed-interface": false,
     "no-object-mutation": false,