Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default tslint json #26

Merged
merged 1 commit into from May 9, 2017
Merged

Add default tslint json #26

merged 1 commit into from May 9, 2017

Conversation

bwnodak
Copy link
Contributor

@bwnodak bwnodak commented May 9, 2017

Thanks for the great custom rules. Unforunately I ran into some troubles when integrating them into a tslint-config package.

Using tslint-immutable in a tslint-config is problematic when using yarn. For example, a tslint-config package would add ./node_modules/tslint-immutable/rules to its rulesDirectory, but if the tslint-config package is installed into another project through yarn, the node_modules folder structure is flattened and the rulesDirectory path can't be found (because tslint-immutable is at the top level of the directory, rather than nested as it would be using npm).

Adding a default tslint-immutable.json to the project allows other tslint-configs to extend it, and not worry about missing rules.

@jonaskello jonaskello merged commit a555774 into jonaskello:master May 9, 2017
@jonaskello
Copy link
Owner

Nice, I was not aware tslint could do this :-). Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants