Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great custom rules. Unforunately I ran into some troubles when integrating them into a tslint-config package.
Using
tslint-immutable
in a tslint-config is problematic when using yarn. For example, a tslint-config package would add./node_modules/tslint-immutable/rules
to its rulesDirectory, but if the tslint-config package is installed into another project through yarn, the node_modules folder structure is flattened and the rulesDirectory path can't be found (because tslint-immutable is at the top level of the directory, rather than nested as it would be using npm).Adding a default
tslint-immutable.json
to the project allows other tslint-configs to extend it, and not worry about missing rules.