fix: improper use of null when interface asks for undefined

jonasmerlin · Jul 21, 2023 · 0447eb3 · 0447eb3
1 parent d6c6d52
commit 0447eb3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/SEO.astro b/src/SEO.astro
@@ -86,9 +86,9 @@ function validateProps(props: Props) {
   if (props.openGraph) {
     if (
       !props.openGraph.basic ||
-      props.openGraph.basic.title == null ||
-      props.openGraph.basic.type == null ||
-      props.openGraph.basic.image == null
+      (props.openGraph.basic.title ?? undefined) == undefined ||
+      (props.openGraph.basic.type ?? undefined) == undefined ||
+      (props.openGraph.basic.image ?? undefined) == undefined
     ) {
       throw new Error(
         "If you pass the openGraph prop, you have to at least define the title, type, and image basic properties!"

diff --git a/src/components/OpenGraphImageTags.astro b/src/components/OpenGraphImageTags.astro
@@ -7,9 +7,5 @@ const { secureUrl, type, width, height, alt } = Astro.props.openGraph.image;
 {secureUrl ? <meta property="og:image:secure_url" content={secureUrl} /> : null}
 {type ? <meta property="og:image:type" content={type} /> : null}
 {width ? <meta property="og:image:width" content={width} /> : null}
-{
-  !(height === null) ? (
-    <meta property="og:image:height" content={height} />
-  ) : null
-}
-{!(alt === null) ? <meta property="og:image:alt" content={alt} /> : null}
+{height ? <meta property="og:image:height" content={height} /> : null}
+{alt ? <meta property="og:image:alt" content={alt} /> : null}