Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position of name and value makes it difficult to quickly read metatag values. #84

Closed
mikeethedude opened this issue Oct 24, 2023 · 3 comments

Comments

@mikeethedude
Copy link
Contributor

I'm willing to submit a pull request for this.

Right now the extended tags (src/components/ExtendedTags.astro) output from this project output with the content before the name and that makes it difficult to parse at a glance.

      content={content}
      http-equiv={httpEquiv}
      media={media}
      name={name}
      property={property}
    />

I'd think it would make it easier if the name and property were the first attributes filled there.

@jonasmerlin
Copy link
Owner

@mikeethedude Thank you for your input! Since this input seems to stem from your experience with using this feature in your project(s), I would be more than happy to merge a pull request improving ergonomics this way. Please feel free to go ahead with this, and I'll put it into the next version!

mikeethedude added a commit to mikeethedude/astro-seo that referenced this issue Oct 24, 2023
@mikeethedude
Copy link
Contributor Author

Awesome! Pull request is open. I think this is a pretty simple swap on properies. See #85

jonasmerlin added a commit that referenced this issue Feb 18, 2024
@jonasmerlin
Copy link
Owner

Landed in 0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants