Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy special attributes to descriptor #2

Merged
merged 3 commits into from Feb 22, 2019
Merged

Copy special attributes to descriptor #2

merged 3 commits into from Feb 22, 2019

Conversation

escaped
Copy link
Collaborator

@escaped escaped commented Feb 17, 2019

In order to make some Django functionalities to work, we have to copy some attributes to the descriptor.

@escaped escaped self-assigned this Feb 17, 2019
@escaped escaped changed the title WIP: Copy special attributes to descriptor Copy special attributes to descriptor Feb 17, 2019
@escaped escaped requested a review from anrie February 17, 2019 20:24
anrie
anrie approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@anrie anrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finde es gut, dass in dem Zuge auch der Extra-Decorator rausfliegt!

Gerne mergen und auf 0.2 bumpen!

@anrie anrie merged commit 9bf591b into master Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anrie anrie anrie approved these changes

Assignees

@escaped escaped

@anrie anrie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@escaped @anrie