Catch exception during trash-move

jonaswinkler · Feb 20, 2022 · f6e65d8 · f6e65d8
1 parent 2c62583
commit f6e65d8
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/documents/signals/handlers.py b/src/documents/signals/handlers.py
@@ -247,7 +247,14 @@ def cleanup_document_deletion(sender, instance, using, **kwargs):
 
             logger.debug(
                 f"Moving {instance.source_path} to trash at {new_file_path}")
-            os.rename(instance.source_path, new_file_path)
+            try:
+                os.rename(instance.source_path, new_file_path)
+            except OSError as e:
+                logger.error(
+                    f"Failed to move {instance.source_path} to trash at "
+                    f"{new_file_path}: {e}. Skipping cleanup!"
+                )
+                return
 
         for filename in (instance.source_path,
                          instance.archive_path,