-
Notifications
You must be signed in to change notification settings - Fork 358
Searchable dropdowns on document details component #154
Conversation
Awesome. I don't have to do anything. |
this.displayValue.splice(index, 1) | ||
let oldValue = this.displayValue | ||
oldValue.splice(index, 1) | ||
this.displayValue = [...oldValue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this overly complicated? .splice()
works in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea because of the change detection you can’t just splice the array you need to set a new one, see https://github.com/ng-select/ng-select#change-detection
Btw, I've played a bit with the styling and tried to set the border coloring when focused to |
Yea I styled them to fit with bootstrap. Code is in the global styles sheet (I put a comment in the input-select but not the tags. See https://github.com/ng-select/ng-select#custom-styles |
* New translations messages.xlf (Luxembourgish) [ci skip] * New translations messages.xlf (French) [ci skip] * New translations messages.xlf (German) [ci skip] * New translations messages.xlf (Portuguese) [ci skip] * New translations messages.xlf (Luxembourgish) [ci skip] * New translations messages.xlf (Portuguese, Brazilian) [ci skip] * New translations messages.xlf (German) [ci skip] * New translations messages.xlf (German) [ci skip]
This closes #152 and includes searchable dropdowns for correspondents / document types / tags with ng-select. The integration is customized to match paperless-ng including using
tag
components with custom colors, etc.