Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Updates to sidebar "Misc" section #482

Merged
merged 10 commits into from Feb 1, 2021
Merged

Updates to sidebar "Misc" section #482

merged 10 commits into from Feb 1, 2021

Conversation

shamoon
Copy link
Contributor

@shamoon shamoon commented Feb 1, 2021

This PR moves the "misc" section of the sidebar and renames it to "info" and updates its contents, see:

106400838-cb9a4100-63d5-11eb-9df3-3216844b1942

Also move to bottom of screen, add suggestions link, change GH icon
@jonaswinkler
Copy link
Owner

Can't test right now. How about scrolling with lots of saved views and opened documents?

@shamoon
Copy link
Contributor Author

shamoon commented Feb 1, 2021

That section just gets pushed down, like one would expect I think. It uses CSS flexbox so only takes up space if its there. See video with a lot of docs, then I close them

Screen.Recording.2021-01-31.at.4.54.55.PM.mov

@shamoon
Copy link
Contributor Author

shamoon commented Feb 1, 2021

Let me fix a couple small CSS bugs

@shamoon
Copy link
Contributor Author

shamoon commented Feb 1, 2021

Okey dokey =)

@jonaswinkler jonaswinkler merged commit da08eec into jonaswinkler:dev Feb 1, 2021
@jonaswinkler
Copy link
Owner

Just a minor nitpick when the menu gets very small

image

@shamoon
Copy link
Contributor Author

shamoon commented Feb 2, 2021

Looks like when the window is very narrow (e.g. left to right) not short, yea? I mean one thing would be to set white-space: nowrap; on the Github button, then we could perhaps add some classes to hide the text of 'suggest an idea' depending on screen size. Want a PR for this or nah?

@jonaswinkler
Copy link
Owner

I think it would be best to put the "Suggest an idea" link on a new line, if too small. (On a side note, some translations are quite a bit longer)

@shamoon
Copy link
Contributor Author

shamoon commented Feb 2, 2021

Yea true. See this: 53265ec

Can submit as PR obviously if you want, LMK

jonaswinkler pushed a commit that referenced this pull request Feb 2, 2021
@jonaswinkler
Copy link
Owner

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants