Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve segment support #3

Closed
wbhob opened this issue Jul 3, 2017 · 5 comments
Closed

Improve segment support #3

wbhob opened this issue Jul 3, 2017 · 5 comments
Assignees
@jonaszuberbuehler

Comments

@wbhob
Copy link

wbhob commented Jul 3, 2017

I have an ion-segment used to switch between templates in my page, but the first header item is stuck to the navbar when switching tabs, instead of vanishing.

Can you please make ion-affixed items check their state?

screen shot 2017-07-02 at 11 10 15 pm
@jonaszuberbuehler
Copy link
Owner

Good point @wbhob. I use it in ion-tabs where this is no issue. Will have a look ASAP.

@jonaszuberbuehler jonaszuberbuehler self-assigned this Jul 3, 2017
jonaszuberbuehler added a commit that referenced this issue Jul 3, 2017
@jonaszuberbuehler
fixes issue #3: Improve segment support
0a7f2fc
@jonaszuberbuehler
Copy link
Owner

jonaszuberbuehler commented Jul 3, 2017 •
edited
Loading

@wbhob Can you try version 1.0.3? Should be on npm. Short feedback appreciated.

@jonaszuberbuehler
Copy link
Owner

Closing since no reply

@wbhob
Copy link
Author

wbhob commented Jul 5, 2017

Yeah sorry, haven't gotten a chance to test yet, I've been super busy with other projects. I'll hopefully get to it today or tomorrow

@jonaszuberbuehler
Copy link
Owner

No worries. Annoying habit from work to close issues if no reply is given within one day :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonaszuberbuehler jonaszuberbuehler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonaszuberbuehler @wbhob