Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ReactNode instead of string in options #14

Closed
lkostrowski opened this issue Jun 2, 2020 · 2 comments
Closed

Allow ReactNode instead of string in options #14

lkostrowski opened this issue Jun 2, 2020 · 2 comments

Comments

@lkostrowski
Copy link

title?: string;

Hi, I find your lib very useful, thanks :)

There is small improvement with zero-cost. Instead of forcing string for title, description etc it should accept ReactNode, so I can inject <Typography> or other formatted node.

I you agree I can make a PR

@jonatanklosko
Copy link
Owner

Makes perfect sense, thanks! Changed in 0b7ae0d and published as 2.0.5.

@lkostrowski
Copy link
Author

You should probably update the readme ;) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants