-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Embed forms in confirm dialog #21
Comments
Hey! The problem with those use cases is that they are likely to vary from case to case and it would be hard to be generic enough. For instance, for entering password you'd make a call to the API before closing the dialog and react differently depending on the response, so it's highly dependent on your setup. I can imagine the library taking a sufficient number of callbacks, but then its API would likely introduce more complexity than needed, as you may as well create a dialog component specific to your use case and use throughout the app. I may consider a more extendable solution in the future, but for now I'd rather stick to the most common confirmation case. |
Hey guys! Since this PR #14, I'm able to embed forms this way:
It's all working perfectly, as you can see in this screenshot: EXCEPT for those errors: Since Material UI's
Thoughts? EDIT: Actually passing the |
Yeah, the dialog is already controlled by this package. Forms seems like a case that needs more customization, perhaps this comment will help. |
This is out of the scope of this package, as it means to maximally encapsulate the dialog markup. For more complex use cases I suggest an alternative approach outlined here. |
It would be amazing if this library supported embedding form inputs and other layout elements for purposes such as:
The text was updated successfully, but these errors were encountered: