Fixes issue#5 Android compression progress #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unnecessary step for progress indicator forced input in method handle call into String type so tryParse for double can work Android was sending double type while iOS was sending a String type. Now progress indicator works fine on Android and iOS
khainhero
changed the title
|
Thank you very much for your contribution in this PR and others. I was out of time and you fixed my lib's specific problems. LGTM. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unnecessary step for progress indicator
forced input in method handle call into String type so tryParse for double can work
Android was sending double type while iOS was sending a String type.
Now progress indicator works fine on Android and iOS