Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature when Hovering on web for Snackbar #2680

Merged
merged 3 commits into from
Feb 27, 2023

Conversation

RafaRuiz
Copy link
Contributor

@RafaRuiz RafaRuiz commented Feb 2, 2023

I've found a few use cases for snackbars where we explain a certain error to the user, even to copy/paste some code in it.
We've seen that in the user experience that users tend to put the mouse on the top to "hold what they're reading", but snackbars are fading out anyway. Some other people aren't interested so it's not that we can keep a snackbar forever there.

By making the methods public, the ones I changed from private to public, we allow the snackbar to stop and fade out when the hover enters and exits.

Pre-launch Checklist

  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or @jonataslaw said the PR is test-exempt.
  • All existing and new tests are passing.

@RafaRuiz
Copy link
Contributor Author

RafaRuiz commented Feb 2, 2023

I don't understand why tests are failing, but they're failing in master too:
image

will try to retry them

@jonataslaw
Copy link
Owner

I think the master was broken at the time you forked it. Resolved a small conflict, and restarted the tests

@jonataslaw
Copy link
Owner

All tests passed. Thanks for your contribution!
LGTM

@jonataslaw jonataslaw merged commit 27899e7 into jonataslaw:master Feb 27, 2023
@RafaRuiz RafaRuiz deleted the feature/hover_snackbar branch February 27, 2023 16:40
@RafaRuiz
Copy link
Contributor Author

Thanks for your dedication @jonataslaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants