Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass@3.9.3 untested ⚠️ #4

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

greenkeeperio-bot
Copy link
Contributor

Hello lovely humans,

node-sass just published its new version 3.9.3.

State No tests ⚠️
Dependency node-sass
New version 3.9.3
Type devDependency

This version is covered by your current version range, but I could not detect automated tests for this project. Without a test suite I can not really tell whether your project still works.

I was looking at the latest commit of your default branch, but GitHub said there is no status attached to it.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴


GitHub Release

Fix filename issues 🚑

In v3.9.0 we began publishing our test suite to npm as part of our release. We did this be compliant with the node-citgm project. Being the citgm would give us early warning of changes in Node that would break Node Sass for users. We'd hoped this would allows to address these issue early and avoid the dozens of bug reports we receive.

However some users have experience issues with some test filenames include unicode characters. Some npm@2 users have also experienced issues with our path names being too long.

As a result we're temporarily reverting the addition of our test suite until we have a solution for these issues.

We're sorry 💖

Noone ever wants to break someone's build. We had expected this minor change to be innocuous.

Unfortunately we had not accounted for the variety of operating environments our +2M monthly downloads would be running on. Although the number of affected users was small, the failure was at times catastrophic.

Having this feature is important to us, but not breaking your builds, and workflows is critical.


The new version differs by 2 commits .

See the full diff.


This pull request was created by greenkeeper.io.

Tired of seeing this sponsor message? ⚡ greenkeeper upgrade

@jonataswalker jonataswalker merged commit 21392a9 into master Sep 6, 2016
@jonataswalker jonataswalker deleted the greenkeeper-node-sass-3.9.3 branch September 6, 2016 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants