Added ./* to package exports field #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addition is to allow bundlers that don't support the "exports" field to work together with others that do. On the other hand, it will help in the future to prevent modules from breaking once they add support for the use of the "exports" field. Example: if ol-contextmenu is used in a module bundled with Rollup and PostCSS, the "exports" field is not taken into account at the scss @import, so the entire path is neccesary. But, if this new bundled module is then imported in another library using Webpack and PostCSS (which supports "exports"), will be a unresolvable conflict without this addition.
jonataswalker
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is to allow bundlers that don't support the "exports" field to work together with others that do. On the other hand, it will help in the future to prevent modules from breaking once they add support for the use of the "exports" field.
Example: if ol-contextmenu is used in a module bundled with Rollup and PostCSS, the "exports" field is not taken into account at the scss @import, so the entire path is neccesary. But, if this new bundled module is then imported in another library using Webpack and PostCSS (which supports "exports"), will be a unresolvable conflict without this addition.