StimulusReflex introduces adapters - refactor accordingly. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-s
changed the title
jonathan-s
commented
Jun 22, 2020
| "webpack": "^4.43.0", | ||
| "webpack-bundle-analyzer": "^3.7.0", | ||
| "webpack-cli": "^3.3.11" | ||
| }, | ||
| "dependencies": { | ||
| "stimulus_reflex": "file:./stimulus_reflex/javascript", |
There was a problem hiding this comment.
Note that this would need to get changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javascript part of stimulus reflex introduces adapters (stimulusreflex/stimulus_reflex#182) so that implementations can be more flexible.
To be compatible with that change we need to use the same adapter here on our side.
Note: Tests are not passing here simply because of the fact that while testing this locally I had moved the stimulusreflex folder into the django-sockpuppet project.