Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add md/mdx files with image URLs without filenames (now fixed in alttexter-ghclient) #6

Conversation

jonathanalgar
Copy link
Owner

@jonathanalgar jonathanalgar commented Jan 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try again...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be better, will manually override

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the LLM generated alt-text and title attributes in this file as they may contain inaccuracies. Explore how the LLM generated them.

@jonathanalgar jonathanalgar merged commit ce0704a into update-alt-texts-using-alttexter Jan 11, 2024
78 checks passed
@jonathanalgar jonathanalgar deleted the update-alt-texts-using-alttexter-add-md branch January 11, 2024 02:50
hwchase17 pushed a commit to langchain-ai/langchain that referenced this pull request Jan 12, 2024
…les across repo (#15357)

**Description:** Batch update of alt text and title attributes for
images in `md` & `mdx` files across the repo using
[alttexter](https://github.com/jonathanalgar/alttexter)/[alttexter-ghclient](https://github.com/jonathanalgar/alttexter-ghclient)
(built using LangChain/LangSmith).

**Limitation:** cannot update `ipynb` files because of [this
issue](#15357 (comment)).
Can revisit when Docusaurus is bumped to v3.

I checked all the generated alt texts and titles and didn't find any
technical inaccuracies. That's not to say they're _perfect_, but a lot
better than what's there currently.


[Deployed](https://langchain-819yf1tbk-langchain.vercel.app/docs/modules/model_io/)
image example:


![chrome_yZQ7BF2GTj](https://github.com/langchain-ai/langchain/assets/93204286/43a9a4d4-70fd-41c4-8978-b6240ff63ffa)

You can see LangSmith traces for all the calls out to the LLM in the PRs
merged into this one:

* jonathanalgar#6
* jonathanalgar#4
* jonathanalgar#3

I didn't add the following files to the PR as the images already have OK
alt texts:

*
https://github.com/langchain-ai/langchain/blob/27dca2d92fbd9c956a1eac7cf885a0ed060ca9ff/docs/docs/integrations/providers/argilla.mdx#L3
*
https://github.com/langchain-ai/langchain/blob/27dca2d92fbd9c956a1eac7cf885a0ed060ca9ff/docs/docs/integrations/providers/apify.mdx#L11

---------

Co-authored-by: github-actions <github-actions@github.com>
@jonathanalgar jonathanalgar changed the title add md files without filename in URL (now fixed in alttexter-ghclient) add md/mdx files with image URLs without filenames (now fixed in alttexter-ghclient) Jan 12, 2024
lz-chen pushed a commit to lz-chen/langchain that referenced this pull request Jan 22, 2024
…les across repo (langchain-ai#15357)

**Description:** Batch update of alt text and title attributes for
images in `md` & `mdx` files across the repo using
[alttexter](https://github.com/jonathanalgar/alttexter)/[alttexter-ghclient](https://github.com/jonathanalgar/alttexter-ghclient)
(built using LangChain/LangSmith).

**Limitation:** cannot update `ipynb` files because of [this
issue](langchain-ai#15357 (comment)).
Can revisit when Docusaurus is bumped to v3.

I checked all the generated alt texts and titles and didn't find any
technical inaccuracies. That's not to say they're _perfect_, but a lot
better than what's there currently.


[Deployed](https://langchain-819yf1tbk-langchain.vercel.app/docs/modules/model_io/)
image example:


![chrome_yZQ7BF2GTj](https://github.com/langchain-ai/langchain/assets/93204286/43a9a4d4-70fd-41c4-8978-b6240ff63ffa)

You can see LangSmith traces for all the calls out to the LLM in the PRs
merged into this one:

* jonathanalgar#6
* jonathanalgar#4
* jonathanalgar#3

I didn't add the following files to the PR as the images already have OK
alt texts:

*
https://github.com/langchain-ai/langchain/blob/27dca2d92fbd9c956a1eac7cf885a0ed060ca9ff/docs/docs/integrations/providers/argilla.mdx#L3
*
https://github.com/langchain-ai/langchain/blob/27dca2d92fbd9c956a1eac7cf885a0ed060ca9ff/docs/docs/integrations/providers/apify.mdx#L11

---------

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant