Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run dnssec options before domain options #101

Merged
merged 1 commit into from Apr 8, 2022

Conversation

ekristen
Copy link
Contributor

@ekristen ekristen commented Apr 5, 2022

systemd-resolved has a bug with DNSSEC. If domains are added prior to setting or changing the DNSSEC setting, the domains use the previous setting, it also seems that it requires a restart of systemd to reset their DNSSEC settings to what they should be.

By moving the DNSSEC stanza this ensures that the DNSSEC setting is applied before any domains are added to resolved which ensures they have the appropriate DNSSEC setting.

To reproduce this you can use a DNS server that doesn't support DNSSEC and then set DOMAIN and DOMAN-ROUTE for a domain you want to resolve, without this change queries will fail, if you restart resolved they will start working.

To validate this works, restart your system, put this change in place and connect to the VPN, queries will work immediately.

@ekristen
Copy link
Contributor Author

ekristen commented Apr 6, 2022

@jonathanio does the above description make sense? Do I need to provide any additional information? Thanks.

@jonathanio
Copy link
Owner

I've had a look at the code, and that's fine. I needed to re-remember if the options were processed in order of the configuration, not in an order defined in the script, and this will work. I thought there should be a test for this change, but none of the other tests explicitly depend on the order of the calls, so I'll just merge.

@jonathanio jonathanio self-assigned this Apr 8, 2022
@jonathanio jonathanio added the Bug label Apr 8, 2022
@jonathanio jonathanio merged commit 4842280 into jonathanio:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants