Refactor eliot-tree into smaller pieces, with tests, that can be used by third parties #17
Conversation
|
Looks reasonable to me. I haven't done a thorough review, because I'm not really familiar with the code, but I don't see any glaring issues. Could we perhaps hook this up to travis-ci.org or some other continuous integration system? |
|
Changes Unknown when pulling 6b0c520 on 16-refactor-into-library into * on master*. |
|
Changes Unknown when pulling 8d33e4e on 16-refactor-into-library into * on master*. |
|
Tests for Also, you can configure coveralls to not comment on pull requests (I find that a bit noisy, but it's your call) and you can set the allowed reduction in coverage before coveralls returns a build failure status. |
|
Thanks @jerith, I've configured coveralls to be less spammy, I didn't know you could configure that stuff. |
| [testenv:pep8] | ||
| deps = pep8 | ||
| basepython = python2.7 | ||
| commands = pep8 eliottree |
There was a problem hiding this comment.
There should be a newline at the end of the file.
|
👍 from me as well, aside from the thing I noted above. |
Refactor eliot-tree into smaller pieces, with tests, that can be used by third parties. (closes #16)
Closes #16.