Fix Detekt warnings

jonathanklee · Jun 15, 2024 · 82f4e00 · 82f4e00
1 parent 180e610
commit 82f4e00
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -24,5 +24,7 @@ jobs:
       run: chmod +x gradlew
     - name: Build with Gradle
       run: ./gradlew assemble
+    - name: Lint with Detekt
+      run: ./gradlew detekt
     - name: Run test with Gradle
       run: ./gradlew test
diff --git a/app/src/main/java/com/klee/sapio/ui/view/AboutActivity.kt b/app/src/main/java/com/klee/sapio/ui/view/AboutActivity.kt
@@ -24,7 +24,11 @@ class AboutActivity : AppCompatActivity() {
 
         mBinding = ActivityAboutBinding.inflate(layoutInflater)
         mBinding.version.text = "v${BuildConfig.VERSION_NAME}"
-        mBinding.ratingRules.text = Html.fromHtml(getString(R.string.rating_rules, RATING_RULES), Html.FROM_HTML_MODE_COMPACT)
+        mBinding.ratingRules.text = Html.fromHtml(
+            getString(R.string.rating_rules, RATING_RULES),
+            Html.FROM_HTML_MODE_COMPACT
+        )
+
         mBinding.ratingRules.movementMethod = LinkMovementMethod.getInstance()
 
         setContentView(mBinding.root)

diff --git a/app/src/main/java/com/klee/sapio/ui/view/MainActivity.kt b/app/src/main/java/com/klee/sapio/ui/view/MainActivity.kt
@@ -54,11 +54,11 @@ class MainActivity : AppCompatActivity() {
             R.id.about -> {
                 val intent = Intent(this@MainActivity, AboutActivity::class.java)
                 startActivity(intent)
-                return true
+                true
             }
             R.id.donate -> {
                 startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(DONATE_URL)))
-                return true
+                true
             }
             else -> super.onOptionsItemSelected(item)
         }

diff --git a/app/src/main/java/com/klee/sapio/ui/view/WarningFragment.kt b/app/src/main/java/com/klee/sapio/ui/view/WarningFragment.kt
@@ -29,7 +29,11 @@ class WarningFragment : Fragment() {
         savedInstanceState: Bundle?
     ): View {
         mBinding = FragmentWarningBinding.inflate(layoutInflater)
-        mBinding.reportAppDescription.text = Html.fromHtml(getString(R.string.warning_desc, AboutActivity.RATING_RULES), Html.FROM_HTML_MODE_LEGACY)
+        mBinding.reportAppDescription.text = Html.fromHtml(
+            getString(R.string.warning_desc, AboutActivity.RATING_RULES),
+            Html.FROM_HTML_MODE_LEGACY
+        )
+
         mBinding.reportAppDescription.movementMethod = LinkMovementMethod.getInstance()
 
         mBinding.proceedButton.setOnClickListener {