New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated react native method createJSModules (since v47) #33

Closed

jrunestone wants to merge 1 commit into jonathanpalma:master from jrunestone:rnv47-deprecated

Contributor

jrunestone commented Mar 3, 2018

Using latest React Native (v47+) breaks compilation since createJSModules is removed. See facebook/react-native@ce6fb33


          Removed deprecated react native method createJSModules (since v47)

16bb441

Owner

jonathanpalma commented Mar 7, 2018

Hey @jrunestone

I just checked this out and I found that it's not a good idea removing the whole createJSModules since it's going to break support for RN < 0.47.

Instead I'm going just to remove @Override annotation on #34

For more info you can follow this thread facebook/react-native#15232

Thanks for your support,
Jonathan Palma ✌️

jonathanpalma closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment