Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't use with Android 10 / AndroidX #62

Closed
velocitysystems opened this issue Jun 16, 2020 · 6 comments · Fixed by #65
Closed

Can't use with Android 10 / AndroidX #62

velocitysystems opened this issue Jun 16, 2020 · 6 comments · Fixed by #65

Comments

@velocitysystems
Copy link
Contributor

Since glidex.forms takes a dependency on Xamarin.Android.Glide this in turn takes a dependency on Xamarin.Android.Support.v4 (>= 28.0.0.1).

We are targeting Android 10 with AndroidX libraries and cannot install the NuGet package.
Is there any workaround or can we expect an updated version to be released?
@jonathanpeppers
Copy link
Owner

It looks like Glide 4.10.0 migrated to AndroidX:

https://github.com/bumptech/glide/releases

But I think we need a new Xamarin.Android.Glide that is based on AndroidX first?

https://github.com/xamarin/XamarinComponents/blob/ea469ecfc61ab0f7820e10031f85ceb33ad3f697/Android/Glide/build.cake#L6

Can you file an issue here? https://github.com/xamarin/XamarinComponents/issues

I'll leave this open, but basically I will publish a new version of glidex.forms once there is a new Xamarin.Android.Glide.

@velocitysystems velocitysystems mentioned this issue Jun 17, 2020
Closed
@velocitysystems
Copy link
Contributor Author

Hi @jonathanpeppers. I have raised an issue with the Xamarin components team but am still awaiting a response.
Just wondering if you may possibly be able to gain some traction on this internally?

@jonathanpeppers jonathanpeppers mentioned this issue Jul 7, 2020
Merged
jonathanpeppers added a commit that referenced this issue Jul 7, 2020
@jonathanpeppers
Use Xamarin.Android.Glide 4.11.0 (#65)
e8ed7b8 
Fixes: #64
Fixes: #62

Some notes on what changes here:

* Bump version to 2.1.x
* `MonoAndroid10.0` is required
* AndroidX is required
* Xamarin.Forms 4.5.x is required
@jonathanpeppers
Copy link
Owner

This should be live shortly: https://www.nuget.org/packages/glidex.forms/2.1.0.470

I didn't test the NuGet package itself, let me know if you have an issue, thanks!

@velocitysystems
Copy link
Contributor Author

velocitysystems commented Jul 7, 2020 via email

@velocitysystems
Copy link
Contributor Author

@jonathanpeppers Tested this morning and works well. I did find a disposing-related issue, but I don't believe it is related to the update and will bug accordingly. Thanks!

@Paul-DotNET
Copy link

Hi @jonathanpeppers ! Thanks for this amazing & useful plugin.
#95 - some images from drawable folder seems not loading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use Xamarin.Android.Glide 4.11.0 jonathanpeppers/glidex
3 participants
@jonathanpeppers @velocitysystems @Paul-DotNET