Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xamarin.Forms 3.3 and IImageViewHandler support #7

Merged
merged 10 commits into from Oct 15, 2018
Merged

Xamarin.Forms 3.3 and IImageViewHandler support #7

merged 10 commits into from Oct 15, 2018

Conversation

jonathanpeppers
Copy link
Owner

Context: xamarin/Xamarin.Forms#3045

Using IImageViewHandler, I can delete a bunch of code!

Updated dependencies:

  • Xamarin.Forms 3.3.0.893527-pre3
  • Xamarin.Android.Support.* 27.0.2

Other fixes:

  • Found a place needed targetSdkVersion="27"
  • Found where I should use class-parse and AndroidCodegenTarget=XAJavaInterop1.
  • My chuck norris image has a broken URL!
  • [build] cleans sample projects, too
  • [build] added handy Install target
  • DebugType=portable

@jonathanpeppers
Update all the things!
dd5b1d8 
NuGets:
- Xamarin.Forms 3.3.0.893527-pre3
- Xamarin.Android.Support.* 27.0.2

Found a place needed targetSdkVersion="27"

Found where I should use `class-parse` and `AndroidCodegenTarget=XAJavaInterop1`.
@jonathanpeppers
My chuck norris image has a broken URL!
72119ae 
Nooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo
@jonathanpeppers
[build] should clean sample projects, too
8f7f61a
@jonathanpeppers
[build] handy Install target
f7bb64e
@jonathanpeppers
[build] proguard.cfg required for latest Xamarin.Forms
479c44b
@jonathanpeppers
Use DebugType=portable everywhere
f9b63b8
@jonathanpeppers
Added ImageViewHandler
216ff20 
So easy. Delete much code.
@jonathanpeppers
Fix for LinkAll: [Preserve] on ImageViewHandler
091f0e8
@jonathanpeppers
Bump version to 1.0.3-pre
fa5f35a
@jonathanpeppers
Oops!
fad8fb3
@jonathanpeppers jonathanpeppers merged commit 381990c into master Oct 15, 2018
@jonathanpeppers jonathanpeppers deleted the xf-3.3 branch October 15, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonathanpeppers