Add IImageSourceHandler for NavigationPage.TitleIconImageSource #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #69 Context: xamarin/Xamarin.Forms#11676 There are certain Android APIs where `IImageViewHandler` is not possible for Xamarin.Forms to be able to call. For example, if you have an `IMenuItem`: menuItem.SetIcon (drawable); `IImageViewHandler` requires an `ImageView` -- so Xamarin.Forms must fall back to `IImageSourceHandler` for this to work at *all*. Adding `IImageSourceHandler` required various refactoring, but things seem to work as before. `IImageViewHandler` appears to be called by Xamarin.Forms when it *should* be, and `IImageSourceHandler` is called as a fallback. Perhaps in MAUI, `IImageViewHandler` should have an additional method for `IMenuItem`? Co-authored-by: Yaser Moradi <ysmoradi@outlook.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #69
Context: xamarin/Xamarin.Forms#11676
There are certain Android APIs where
IImageViewHandleris notpossible for Xamarin.Forms to be able to call. For example, if you
have an
IMenuItem:IImageViewHandlerrequires anImageView-- so Xamarin.Forms mustfall back to
IImageSourceHandlerfor this to work at all.Adding
IImageSourceHandlerrequired various refactoring, but thingsseem to work as before.
IImageViewHandlerappears to be called byXamarin.Forms when it should be, and
IImageSourceHandleris calledas a fallback.
Perhaps in MAUI,
IImageViewHandlershould have an additional methodfor
IMenuItem?