Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain markdown shows a negative sentiment #62

Closed
jonathanpeppers opened this issue Jan 14, 2022 · 1 comment · Fixed by #73
Closed

Certain markdown shows a negative sentiment #62

jonathanpeppers opened this issue Jan 14, 2022 · 1 comment · Fixed by #73
Assignees
@rolfbjarne
Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!

Comments

@jonathanpeppers
Copy link
Owner

I noticed an image tag is negative, lol:

image

Somewhat related to how we fixed code blocks in 927031a. Maybe we can use the same idea and replace some markdown expressions with spaces?
@jonathanpeppers jonathanpeppers added the up-for-grabs Anyone can work on this. Assign yourself and give it a shot! label Jan 14, 2022
@rachelkang
Copy link
Collaborator

I'm seeing [image] gets picked up as 'brief' now, but not negative
I think maybe whatever you wrote on the next line may have made it 'negative'

@rolfbjarne rolfbjarne self-assigned this Jan 28, 2022
rolfbjarne added a commit that referenced this issue Jan 28, 2022
@rolfbjarne
Skip image tags when analyzing text.
73d9792 
Fixes: #62

Skip image tags when analyzing text.

This is done by replacing image tags with spaces before sending text off to be
analyzed (this way analyzed text has the same location information as the
input).
@rolfbjarne rolfbjarne mentioned this issue Jan 28, 2022
Merged
jonathanpeppers pushed a commit that referenced this issue Feb 5, 2022
@rolfbjarne
Skip image tags when analyzing text. (#73)
570f16d 
Fixes: #62

Skip image tags when analyzing text.

This is done by replacing image tags with spaces before sending text off to be
analyzed (this way analyzed text has the same location information as the
input).

* Rework to keep the alt text, and add dots.

We need to end each section of words with a `.`, so this is understood by
Azure Text Analytics as a separate sentence.
@Eilon Eilon mentioned this issue Jul 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolfbjarne rolfbjarne

Labels
up-for-grabs Anyone can work on this. Assign yourself and give it a shot!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip image tags when analyzing text. jonathanpeppers/inclusive-code-reviews-browser
3 participants
@rolfbjarne @jonathanpeppers @rachelkang