New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create_prompt_application missing from 2.x #647
Comments
Hi @ibeex, IPython does indeed not yet run on prompt_toolkit 2.0. They're working hard on that. If you have some time available, it would be great if you could help them testing the latest IPython version from GitHub. |
Actually, many of these applications have pull requests to upgrade to prompt_toolkit 2.0, but they need a little more (help with) testing before getting merged. For now, in any case, they have specified 1.0 in their setup.py. See:
|
IPython merged, but is there a porting guide for all other apps? |
There is: https://python-prompt-toolkit.readthedocs.io/en/2.0/pages/upgrading.html |
For anyone needing a temporary workaround, I can confirm that reverting to v.1.x mostly resolves the errors that prevent ipython, ptpython, etc. from initializing:
You might get the following error when launching ptpython if you're using the default
...but it's not fatal, and can be safely ignored, or you could delete the offending lines. A quick glance at the code suggests KeyPress is only used to map the 'jj' key sequence to 'Esc' in vim mode. |
@jonathanslenders Weird... the kludge above worked for me yesterday, but it's throwing the following stacktrace today:
Can you suggest a better workaround? I'm utterly hooked on your excellent ptpython REPL and I'm afraid I don't understand the nature of these breaking changes well enough to patch them. Edit: my bad, I assumed incorrectly that running "python3 setup.py install" would replace the existing prompt-toolkit installation -- it doesn't. I'm guessing this worked yesterday only because I was already in the cloned downstream branch. I'll edit the instructions. |
I think this issue could be closed :) |
Ok, closing it. Feel free to open again if needed. |
ipython and lots off other apps don't work any more.
The text was updated successfully, but these errors were encountered: