Avoid resolving promise with undefined; always throwing not found error. #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core promise can resolve to
undefined
since there is no fallback return / throw statement.In the (very common) scenario where the import file is (1) correctly formed (ends with
.css
, etc.) but (2) does not exist, the promise will resolve toundefined
instead of rejecting. This is especially problematic when walking through an array of possible paths where the import might be located, as inpostcss-advanced-variables
'simportPaths
directive:https://github.com/jonathantneal/postcss-advanced-variables#importpaths