-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sourcery refactored master branch #1
base: master
Are you sure you want to change the base?
Conversation
if title is None: | ||
self.title = self.DEFAULT_TITLE | ||
else: | ||
self.title = title | ||
self.title = self.DEFAULT_TITLE if title is None else title |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HTMLTestRunner.__init__ refactored with the following changes:
- Replace if statement with if expression
r = [(cls, rmap[cls]) for cls in classes] | ||
return r | ||
return [(cls, rmap[cls]) for cls in classes] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HTMLTestRunner.sortResult refactored with the following changes:
- Inline variable that is only used once
if status: | ||
status = ' '.join(status) | ||
else: | ||
status = 'none' | ||
status = ' '.join(status) if status else 'none' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HTMLTestRunner.getReportAttributes refactored with the following changes:
- Replace if statement with if expression
heading = self.HEADING_TMPL % dict( | ||
title = saxutils.escape(self.title), | ||
parameters = ''.join(a_lines), | ||
description = saxutils.escape(self.description), | ||
) | ||
return heading | ||
return self.HEADING_TMPL % dict( | ||
title = saxutils.escape(self.title), | ||
parameters = ''.join(a_lines), | ||
description = saxutils.escape(self.description), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HTMLTestRunner._generate_heading refactored with the following changes:
- Inline variable that is only used once
report = self.REPORT_TMPL % dict( | ||
test_list = ''.join(rows), | ||
count = str(result.success_count+result.failure_count+result.error_count), | ||
Pass = str(result.success_count), | ||
fail = str(result.failure_count), | ||
error = str(result.error_count), | ||
return self.REPORT_TMPL % dict( | ||
test_list=''.join(rows), | ||
count=str( | ||
result.success_count + result.failure_count + result.error_count | ||
), | ||
Pass=str(result.success_count), | ||
fail=str(result.failure_count), | ||
error=str(result.error_count), | ||
) | ||
return report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function HTMLTestRunner._generate_report refactored with the following changes:
- Simplify conditional into switch-like form
- Inline variable that is only used once
Branch
master
refactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
master
branch, then run: