Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: using inline css & js in index.html to decrease load time #548

Merged
merged 3 commits into from
May 14, 2023
Merged

perf: using inline css & js in index.html to decrease load time #548

merged 3 commits into from
May 14, 2023

Conversation

OutdatedGuy
Copy link
Contributor

Adds the splash screen related css and js code in html head tag as inline instead of using script:src and link:stylesheet.

Automatically migrates previously set script:src and link:stylesheet code to inline.

closes #500

@OutdatedGuy OutdatedGuy marked this pull request as draft May 14, 2023 20:56
@OutdatedGuy OutdatedGuy marked this pull request as ready for review May 14, 2023 20:57
@OutdatedGuy OutdatedGuy changed the title perf: using inline css & js to decrease load time perf: using inline css & js in index.html to decrease load time May 14, 2023
@OutdatedGuy OutdatedGuy reopened this May 14, 2023
@OutdatedGuy OutdatedGuy reopened this May 14, 2023
@OutdatedGuy
Copy link
Contributor Author

@jonbhanson, ran GitHub actions successfully

@jonbhanson jonbhanson merged commit b996049 into jonbhanson:master May 14, 2023
1 of 3 checks passed
@OutdatedGuy OutdatedGuy deleted the perf/inline-scripts-and-styles branch May 14, 2023 23:08
doananhtuan22111996 pushed a commit to lux-studio-66/flutter_native_splash that referenced this pull request May 27, 2023
…hanson#548)

* perf: using inline css & js to decrease load time

* refactor: remove unused constant variables

(cherry picked from commit b996049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving the splash JS and CSS to be inline within index.html improves load time for HTML Web builds
2 participants