Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example app for Flutter 3.10 #551

Merged
merged 2 commits into from May 15, 2023
Merged

chore: update example app for Flutter 3.10 #551

merged 2 commits into from May 15, 2023

Conversation

OutdatedGuy
Copy link
Contributor

No description provided.

@OutdatedGuy
Copy link
Contributor Author

@jonbhanson, ran GitHub actions successfully

@bartekpacia
Copy link

Please also add namespace to build.gradle in the android and example/android directories.

Currently this package causes Gradle builds using AGP v8 to fail with:

$ ./gradlew :app:assembleDebug

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring project ':flutter_native_splash'.
> Could not create an instance of type com.android.build.api.variant.impl.LibraryVariantBuilderImpl.
   > Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

     android {
         namespace 'com.example.namespace'
     }

     If the package attribute is specified in the source AndroidManifest.xml, it can be migrated automatically to the namespace value in the build.gradle file using the AGP Upgrade Assistant; please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 913ms

@OutdatedGuy
Copy link
Contributor Author

OutdatedGuy commented May 15, 2023

@bartekpacia, I'll create a separate PR to add support for AGP 8.

Looks like the support is already added in this PR, just have to wait till @jonbhanson publishes new release with these changes.

@jonbhanson jonbhanson merged commit 47c18d7 into jonbhanson:master May 15, 2023
1 check passed
@OutdatedGuy OutdatedGuy deleted the chore/update-example-app branch May 15, 2023 16:43
doananhtuan22111996 pushed a commit to lux-studio-66/flutter_native_splash that referenced this pull request May 27, 2023
* chore: update example app for Flutter 3.10

* chore: update build gradle file for latest syntax

(cherry picked from commit 47c18d7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants