Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exit process with error code when unexpected config provided in YAML #657

Conversation

smit-ghl
Copy link
Contributor

@smit-ghl smit-ghl commented Jan 25, 2024

Current behavior:

  • When provided invalid configuration in YAML for flutter_native_splash and ran dart run flutter_native_splash:create command, process exits with 0 code. This indicates process completed successfully without any issue.

What's change:

  • With this PR, the process exits with error code to indicate the command failed to get executed.

🐞 This PR fixes #656 .


CI/CD pipeline wasn't failing before due to process completed with success code (exit(0)):

CI-CD-pipeline-before-change

CI/CD pipeline fails with this PR changes because process now exits with error (exit(1)):

CI-CD-pipeline-after-change

@jonbhanson jonbhanson merged commit 612d985 into jonbhanson:master Jan 26, 2024
jonbhanson added a commit that referenced this pull request Jan 28, 2024
…with error code when unexpected config provided in YAML. Thanks smit-ghl for PR #657. Updated readme.  Thanks Mercutio1243 for the suggestions.  Closes #658.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Process exits with success code in case of invalid YAML configuration
2 participants