Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search feature #61

Closed
jonbiemond opened this issue Oct 21, 2023 · 8 comments
Closed

Add search feature #61

jonbiemond opened this issue Oct 21, 2023 · 8 comments
Assignees
Labels
backend Change to the backend enhancement New feature or request frontend Change to the frontend

Comments

@jonbiemond
Copy link
Owner

Add the ability to search by course name.

@jonbiemond jonbiemond added frontend Change to the frontend backend Change to the backend labels Oct 21, 2023
@Dominik26-1
Copy link
Contributor

Dominik26-1 commented Oct 25, 2023

I would like to contribute to this issue especially for backend part. Can you assign to me and add more details? @jonbiemond

@jonbiemond
Copy link
Owner Author

@Dominik26-1 I've assigned you! Feel free to focus on just the backend for now. I'll add more details soon.

@Dominik26-1
Copy link
Contributor

Dominik26-1 commented Oct 25, 2023

I think, its so far so clear. I've already started on it. Can you please give me permission to push to my created development branch and create PR.

remote: Permission to jonbiemond/BCIT-Flex.git denied to Dominik26-1.
fatal: unable to access 'https://github.com/jonbiemond/BCIT-Flex.git/'

@jonbiemond
Copy link
Owner Author

Hi @Dominik26-1 , instead of pushing changes directly to this repo could you please create a fork and make the changes there?

See details on how to create a fork here: https://docs.github.com/en/get-started/quickstart/fork-a-repo
And since you've already made the changes in a clone of this repo, here's how you can make the new fork the remote for your local version: https://docs.github.com/en/get-started/quickstart/fork-a-repo

@jonbiemond jonbiemond added the enhancement New feature or request label Oct 25, 2023
@jonbiemond
Copy link
Owner Author

Hey @Dominik26-1, I look forward to seeing your PR! Is there anything I can help with?

@Dominik26-1
Copy link
Contributor

Dominik26-1 commented Nov 1, 2023

Hi, I had locally prepared PR but I noticed you changed main code so need to update my changes with yours.

@jonbiemond
Copy link
Owner Author

Hey @Dominik26-1, don't worry about that for now. Let's leave it as the very last step before merging. I can also help resolve any conflicts.

@Dominik26-1
Copy link
Contributor

I created PR some minutes ago, so you can have a look (add some functionality for not exact matching, make sense for me to not only return records with the same word)

jonbiemond pushed a commit to Dominik26-1/BCIT-Flex that referenced this issue Nov 3, 2023
jonbiemond pushed a commit that referenced this issue Nov 3, 2023
@jonbiemond jonbiemond mentioned this issue Nov 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Change to the backend enhancement New feature or request frontend Change to the frontend
Projects
Status: Done
Development

No branches or pull requests

2 participants