-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests after #44 is merged #48
Conversation
a84e0fc
to
7103411
Compare
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
7103411
to
d97c498
Compare
a0433b4
to
d97c498
Compare
I will take a look at this over the rest of the holiday break and see if I can come up with something. I need to familiarize myself with what #44 added. I know it included AfterFunc and uses callbacks rather than channels, but I am unfamiliar with the particulars, specifically the "Otherwise it addresses a number of bugs, mainly around out-of-order or duplicate delivery of events, as exposed by the various tests added by these changes." |
Figured it out. Fixes incoming. Pardon me as I am still figuring out Github. |
Appreciate it! |
Turns out this was mostly a timeout issue. I made #51 to address that and standardize a bit. While I was going down the rabbit hole, I the control of |
This is done |
Fixes test failures introduced in #44
Signed-off-by: Mark Sagi-Kazar mark.sagikazar@gmail.com